Refactor authors dropdown (send get request from frontend to avoid long wait time) #23890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
reviewed
Apr 4, 2023
silverwind
reviewed
Apr 4, 2023
GiteaBot
added
lgtm/need 1
lunny
reviewed
Apr 6, 2023
lunny
approved these changes
Apr 6, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.19. @HesterG, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
lunny
removed
reviewed/wait-merge
|
It's hard to backport this PR, so I removed the label. |
lunny
removed
the
backport/manual
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 7, 2023
* upstream/main: Clean template/helper.go (go-gitea#23922) Remove `Repository.getFilesChanged` to fix Actions `paths` and `paths-ignore` filter (go-gitea#23920) Hardcode path to docker images (go-gitea#23955) Title can be empty when creating tag only (go-gitea#23917) Actions: Use default branch as ref when a branch/tag delete occurs (go-gitea#23910) Refactor authors dropdown (send get request from frontend to avoid long wait time) (go-gitea#23890) [skip ci] Updated translations via Crowdin Merge `push to create`, `open PR from push`, and `push options` docs articles into one (go-gitea#23744) Delete deleted release attachments immediately from storage (go-gitea#23913) More specific and unique feed name for NuGet install command template. (go-gitea#23889) Treat PRs with agit flow as fork PRs when triggering actions. (go-gitea#23884) Use graceful editorconfig loader to reduce errors when loading malformed editorconfigs (go-gitea#21257) Remove -v from vulncheck (go-gitea#23953) Improve permission check of packages (go-gitea#23879) Adjust some documentations titles (go-gitea#23941)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the authors search dropdown might take a long time to load if amount of authors is huge.
Example: (In the video below, there are about 10000 authors, and it takes about 10 seconds to open the author dropdown)
default.mov
Possible improvements can be made, which will take 2 steps (Thanks to @wolfogre for advice):
Step 1：
Backend: Add a new api, which returns a limit of 30 posters with matched prefix.
Frontend: Change the search behavior from frontend search(fomantic search) to backend search(when input is changed, send a request to get authors matching the current search prefix)
Step 2：
Backend: Optimize the api in step 1 using indexer to support fuzzy search.
This PR is implements the first step. The main changes:
GET /{type:issues|pulls}/posters, which return a limit of 30 users with matched prefix (prefix sent as query). IfDEFAULT_SHOW_FULL_NAMEincustom/conf/app.iniis set to true, will also include fullnames fuzzy search.After:
default.mov
Fixes: #22586