Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deleted release attachments immediately from storage #23913

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 4, 2023

Previously, deleted release attachments were kept forever on the external storage.
Note: It may be very slow now if there are many attachments to be deleted on this release.

Fix #23728

@lunny lunny added type/bug outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 4, 2023
@lunny lunny added this to the 1.20.0 milestone Apr 4, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 5, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #23913 (081c3ea) into main (f521e88) will decrease coverage by 0.25%.
The diff coverage is 30.19%.

@@            Coverage Diff             @@
##             main   #23913      +/-   ##
==========================================
- Coverage   47.14%   46.90%   -0.25%     
==========================================
  Files        1149     1159      +10     
  Lines      151446   153189    +1743     
==========================================
+ Hits        71397    71846     +449     
- Misses      71611    72833    +1222     
- Partials     8438     8510      +72     
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.63% <0.00%> (-0.10%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
... and 74 more

... and 79 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 6, 2023
@delvh delvh changed the title Fix release attachments immediately when updating Delete deleted release attachments immediately from storage Apr 6, 2023
@jolheiser jolheiser enabled auto-merge (squash) April 6, 2023 21:36
@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit e5dcd6a into go-gitea:main Apr 6, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 6, 2023
…#23913)

Previously, deleted release attachments were kept forever on the
external storage.
Note: It may be very slow now if there are many attachments to be
deleted on this release.

Fix go-gitea#23728
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 6, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 6, 2023
jolheiser pushed a commit that referenced this pull request Apr 6, 2023
…23958)

Backport #23913 by @lunny

Previously, deleted release attachments were kept forever on the
external storage.
Note: It may be very slow now if there are many attachments to be
deleted on this release.

Fix #23728

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 7, 2023
* upstream/main:
  Clean template/helper.go (go-gitea#23922)
  Remove `Repository.getFilesChanged` to fix Actions `paths` and `paths-ignore` filter (go-gitea#23920)
  Hardcode path to docker images (go-gitea#23955)
  Title can be empty when creating tag only (go-gitea#23917)
  Actions: Use default branch as ref when a branch/tag delete occurs (go-gitea#23910)
  Refactor authors dropdown (send get request from frontend to avoid long wait time) (go-gitea#23890)
  [skip ci] Updated translations via Crowdin
  Merge `push to create`, `open PR from push`, and `push options` docs articles into one (go-gitea#23744)
  Delete deleted release attachments immediately from storage (go-gitea#23913)
  More specific and unique feed name for NuGet install command template. (go-gitea#23889)
  Treat PRs with agit flow as fork PRs when triggering actions. (go-gitea#23884)
  Use graceful editorconfig loader to reduce errors when loading malformed editorconfigs (go-gitea#21257)
  Remove -v from vulncheck (go-gitea#23953)
  Improve permission check of packages (go-gitea#23879)
  Adjust some documentations titles (go-gitea#23941)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
@lunny lunny deleted the lunny/fix_attachments branch August 24, 2023 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attachments are not deleted in Minio storage after removing them from a Release
7 participants