Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title can be empty when creating tag only #23917

Merged
merged 4 commits into from
Apr 7, 2023

Conversation

Zettat123
Copy link
Contributor

@Zettat123 Zettat123 commented Apr 4, 2023

Fixes #23809

Make the title not required. If the title is empty when creating release (not tag), an error message will be displayed.

image

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #23917 (7b69535) into main (f521e88) will decrease coverage by 0.16%.
The diff coverage is 30.93%.

❗ Current head 7b69535 differs from pull request most recent head ac9c64e. Consider uploading reports for the commit ac9c64e to get more accurate results

@@            Coverage Diff             @@
##             main   #23917      +/-   ##
==========================================
- Coverage   47.14%   46.99%   -0.16%     
==========================================
  Files        1149     1159      +10     
  Lines      151446   153196    +1750     
==========================================
+ Hits        71397    71990     +593     
- Misses      71611    72713    +1102     
- Partials     8438     8493      +55     
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.63% <0.00%> (-0.10%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
... and 74 more

... and 84 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 4, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 4, 2023
@lunny lunny added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Apr 4, 2023
@lunny lunny added this to the 1.20.0 milestone Apr 4, 2023
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 4, 2023
@silverwind
Copy link
Member

Should not backport because of new translation.

@wxiaoguang
Copy link
Contributor

We have this tool now

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 5, 2023
@lunny lunny enabled auto-merge (squash) April 7, 2023 01:21
@lunny lunny merged commit ed7245f into go-gitea:main Apr 7, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 7, 2023
Fixes go-gitea#23809

Make the title not required. If the title is empty when creating release
(not tag), an error message will be displayed.

![image](https://user-images.githubusercontent.com/15528715/229761056-c52e338b-5f25-4d7d-bb44-2cb0304abcee.png)
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 7, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 7, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 7, 2023
* upstream/main:
  Clean template/helper.go (go-gitea#23922)
  Remove `Repository.getFilesChanged` to fix Actions `paths` and `paths-ignore` filter (go-gitea#23920)
  Hardcode path to docker images (go-gitea#23955)
  Title can be empty when creating tag only (go-gitea#23917)
  Actions: Use default branch as ref when a branch/tag delete occurs (go-gitea#23910)
  Refactor authors dropdown (send get request from frontend to avoid long wait time) (go-gitea#23890)
  [skip ci] Updated translations via Crowdin
  Merge `push to create`, `open PR from push`, and `push options` docs articles into one (go-gitea#23744)
  Delete deleted release attachments immediately from storage (go-gitea#23913)
  More specific and unique feed name for NuGet install command template. (go-gitea#23889)
  Treat PRs with agit flow as fork PRs when triggering actions. (go-gitea#23884)
  Use graceful editorconfig loader to reduce errors when loading malformed editorconfigs (go-gitea#21257)
  Remove -v from vulncheck (go-gitea#23953)
  Improve permission check of packages (go-gitea#23879)
  Adjust some documentations titles (go-gitea#23941)
lunny pushed a commit that referenced this pull request Apr 7, 2023
Backport #23917 by @Zettat123

Fixes #23809

Make the title not required. If the title is empty when creating release
(not tag), an error message will be displayed.

![image](https://user-images.githubusercontent.com/15528715/229761056-c52e338b-5f25-4d7d-bb44-2cb0304abcee.png)

Co-authored-by: Zettat123 <zettat123@gmail.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Tag Only on New release should not require a Title
6 participants