Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 in the API if the requested webhooks were not found (#24823) #24830

Merged
merged 2 commits into from
May 21, 2023
Merged

Return 404 in the API if the requested webhooks were not found (#24823) #24830

merged 2 commits into from
May 21, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #24823 by @sonjek

Should resolve first point of the issue #24574

@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them type/bug labels May 21, 2023
@GiteaBot GiteaBot added this to the 1.19.4 milestone May 21, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 21, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 21, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 21, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 21, 2023
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 21, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) May 21, 2023 17:26
@techknowlogick techknowlogick merged commit f29c52a into go-gitea:release/v1.19 May 21, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 21, 2023
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jun 3, 2023
@GiteaBot @earl-warren
Return 404 in the API if the requested webhooks were not found (go-…
16bccee 
…gitea#24823) (go-gitea#24830)

Backport go-gitea#24823 by @sonjek

Should resolve first point of the issue
go-gitea#24574

Co-authored-by: Yevhen Pavlov <yevhen.pavlov.ua@gmail.com>
(cherry picked from commit f29c52a)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 20, 2023
@techknowlogick techknowlogick deleted the backport-24823-v1.19 branch September 9, 2023 05:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.19.4
Development

Successfully merging this pull request may close these issues.
5 participants
@GiteaBot @lunny @delvh @techknowlogick @sonjek