Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ref for workflows triggered by pull_request_target #25743

Merged
merged 7 commits into from
Jul 7, 2023

Conversation

Zettat123
Copy link
Contributor

@Zettat123 Zettat123 commented Jul 7, 2023

Follow #25229

At present, when the trigger event is pull_request_target, the ref and sha of ActionRun are set according to the base branch of the pull request. This makes it impossible for us to find the head branch of the ActionRun directly. In this PR, the ref and sha will always be set to the head branch and they will be changed to the base branch when generating the task context.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 7, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2023
@Zettat123 Zettat123 changed the title Fix ref for workflows triggered by pull_request_event Fix ref for workflows triggered by pull_request_target Jul 7, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 7, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 7, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 7, 2023
@silverwind silverwind enabled auto-merge (squash) July 7, 2023 16:07
@silverwind silverwind merged commit a42a838 into go-gitea:main Jul 7, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jul 7, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 7, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants