-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing triggers to update issue indexer #26539
Merged
lunny
merged 2 commits into
go-gitea:main
from
wolfogre:bugfix/index_issue_for_new_comment
Aug 16, 2023
Merged
Add missing triggers to update issue indexer #26539
lunny
merged 2 commits into
go-gitea:main
from
wolfogre:bugfix/index_issue_for_new_comment
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Aug 16, 2023
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Aug 16, 2023
wolfogre
changed the title
Add missing triggers to update issue index
Add missing triggers to update issue indexer
Aug 16, 2023
delvh
approved these changes
Aug 16, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Aug 16, 2023
lunny
approved these changes
Aug 16, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Aug 16, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Aug 16, 2023
wxiaoguang
approved these changes
Aug 16, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Aug 16, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 17, 2023
* upstream/main: Sync repo's IsEmpty status correctly (go-gitea#26517) [skip ci] Updated translations via Crowdin Remove fomantic transition module (go-gitea#26469) Explain SearchOptions and fix ToSearchOptions (go-gitea#26542) Update go dependencies (go-gitea#26534) Differentiate better between user settings and admin settings (go-gitea#26538) Add missing triggers to update issue indexer (go-gitea#26539) Improve deadline icon location in milestone list page (go-gitea#26532) Use unique class for breadcrumb divider (go-gitea#26524) Fix typo of RunerOwnerID (go-gitea#26508) Improve clickable area in repo action view page (go-gitea#26115) Fix dark theme highlight for "NameNamespace" (go-gitea#26519) Remove duplicate CSS import for chroma/base.css (go-gitea#26523) Fix project filter bugs (go-gitea#26490) Fix display problems of members and teams unit (go-gitea#26363) Use `hidden` over `clip` for text truncation (go-gitea#26520) Add API route to list org secrets (go-gitea#26485) Set "type=button" for editor's toolbar buttons (go-gitea#26510) Apply to become a maintainer (go-gitea#26514) Detect ogg mime-type as audio or video (go-gitea#26494)
wolfogre
added a commit
that referenced
this pull request
Aug 17, 2023
Provide a way to rebuild issue indexer manually. So if the indexer get outdated because of some bugs like #26539, we can rebuild it. <img width="1104" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/ac242e29-6f04-47ca-b3d0-801a796448d3"> Co-authored-by: Giteabot <teabot@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26536
Follow #26012
Whatever the comment type is, always update the issue indexer. So the issue indexer will be updated when there is a change in Status, Assignee, Label, and so on.
I added the logic for
NotifyUpdateComment
, but missed it forNotifyCreateIssueComment
andNotifyDeleteComment
.