Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated Id method with ID #2655

Merged
merged 2 commits into from
Oct 5, 2017

Conversation

ethantkoenig
Copy link
Member

@lafriks
Copy link
Member

lafriks commented Oct 4, 2017

Oh well, let it be than LGTM :)

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 4, 2017
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 4, 2017
@lafriks lafriks added this to the 1.3.0 milestone Oct 4, 2017
@ethantkoenig
Copy link
Member Author

@lafriks Figured it would be easier to just fix at once

@codecov-io
Copy link

codecov-io commented Oct 4, 2017

Codecov Report

Merging #2655 into master will not change coverage.
The diff coverage is 30.26%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2655   +/-   ##
=======================================
  Coverage   27.12%   27.12%           
=======================================
  Files          86       86           
  Lines       17064    17064           
=======================================
  Hits         4629     4629           
  Misses      11757    11757           
  Partials      678      678
Impacted Files Coverage Δ
models/models.go 28.83% <ø> (ø) ⬆️
models/ssh_key.go 10.6% <0%> (ø) ⬆️
models/user_openid.go 28.98% <0%> (ø) ⬆️
models/issue_watch.go 84.21% <0%> (ø) ⬆️
models/repo_mirror.go 0.63% <0%> (ø) ⬆️
models/update.go 11.17% <0%> (ø) ⬆️
models/branches.go 0% <0%> (ø) ⬆️
models/gpg_key.go 30.28% <0%> (ø) ⬆️
models/twofactor.go 0% <0%> (ø) ⬆️
models/login_source.go 0% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1266a1...8ac185b. Read the comment docs.

@daviian
Copy link
Member

daviian commented Oct 4, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 4, 2017
@lafriks lafriks merged commit aa962de into go-gitea:master Oct 5, 2017
@ethantkoenig ethantkoenig deleted the refactor/id branch October 5, 2017 22:49
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants