fix duplicated icon in repolist

[denyskon]

Fix #27596

Only show fork/mirror icon in title if the main icon is something else.

[lng2020]

This PR

This PR will solve the problem but it's a little hacky. It uses the order of avatar icons, which is
confused when the reviewer didn't know about the sequence in

gitea/templates/repo/icon.tmpl

Lines 1 to 14 in c37f95f

	{{$avatarLink := (.RelAvatarLink ctx)}}
	{{if $avatarLink}}
	<img class="ui avatar gt-vm" src="{{$avatarLink}}" width="32" height="32" alt="{{.FullName}}">
	{{else if $.IsTemplate}}
	{{svg "octicon-repo-template" 32}}
	{{else if $.IsPrivate}}
	{{svg "octicon-lock" 32}}
	{{else if $.IsMirror}}
	{{svg "octicon-mirror" 32}}
	{{else if $.IsFork}}
	{{svg "octicon-repo-forked" 32}}
	{{else}}
	{{svg "octicon-repo" 32}}
	{{end}}

Another design

Personally speaking, I think we should redesign those icons. I will share my opinion here but I won't be a blocker for this PR here since I have no preference for UI.

There are two kinds of labels after the repo name. The first one is the "label list", showing four kinds of repo: private, internal, private template, and internal template. I think it's a little weird because the private/internal and template are not so connected.

The second kind of label is the fork and mirror icons, which is pretty strange to me as to why those two icons are special. So I did some research and found out this pr.

The original code logic didn't split the fork and mirror, it just used else if to add the label. But this PR split the code. The author explained that why he doing this(#11891 (comment)), which is reasonable to me. Here is the quote.

Fork and mirror icon is kept, ideally in future we would display where repo is forked/mirrored from right on the explore page, like we do on repo header itself. We could then move mirror/fork icon along with source link to second line.

But before we add the original URL for the fork/mirror repo, the avatar icon is introduced. So it looks duplicated sometimes.

So here I want to propose a new design:

1. The avatar icon includes four kinds: user-define repo avatar, mirror icon, fork icon, and default icon.
2. A label to indicate whether it's private/internal.
3. A label to indicate whether it's a template.
4. A label to indicate whether it's an archive.

This design wouldn't hide information too because a repo can't both be the mirror(pull mirror) and fork.

(It seems that a fork of a template repo will not be a template either, not sure whether it's a bug.)
Edited: It's not a template after being forked, but it can be a template by changing settings

[denyskon]

I think your proposal is reasonable. I'm on vacation currently, so I don't know whether I'll have the possibility to implement it in the next few days.

[lng2020]

I think your proposal is reasonable. I'm on vacation currently, so I don't know whether I'll have the possibility to implement it in the next few days.

Sorry to bother you on this. Happy vacation😄. I will try to implement it in the next few days.

[denyskon]

Oh it's okay, but thanks :) Here is the new PR: #27644