Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement contributors graph #27880

Closed
wants to merge 103 commits into from
Closed

Implement contributors graph #27880

wants to merge 103 commits into from

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 2, 2023

Continuation of #25439.

@sahinakkaya you have push access to my fork to continue working on it.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 2, 2023
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 2, 2023
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/frontend labels Nov 2, 2023
@silverwind
Copy link
Member Author

silverwind commented Nov 2, 2023

I did some layout fixes in b71882c, now looks like this:

Screenshot 2023-11-02 at 20 25 18

Open bugs that I noticed:

  1. I'm incorrectly shown multiple times, it should only show one box per Gitea account.
  2. Colors need adjustment for dark theme.
  3. "Commits" should be a link and spacing needs tweaks.

@silverwind silverwind added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Nov 2, 2023
@denyskon
Copy link
Member

denyskon commented Nov 2, 2023

@silverwind I don't have an overview of what's implemented in this PR, but maybe you used different mail addresses? Don't we then need mailmap support?

@silverwind
Copy link
Member Author

silverwind commented Nov 2, 2023

Yes, different e-mail addresses and author name case because of commits from web ui. We need to dedupe based on associated Gitea account.

@sahinakkaya
Copy link
Contributor

  1. I'm incorrectly shown multiple times, it should only show one box per Gitea account.

IIRC, it should show a box per mail address. Maybe you used 3 different mail address as committer email?

@silverwind
Copy link
Member Author

silverwind commented Nov 2, 2023

Yes:

$ git log | grep Author: | sort | uniq
Author: Silverwind <silverwind@noreply.localhost>
Author: silverwind <silverwind2@noreply.localhost>
Author: silverwind <silverwind3@noreply.localhost>

Gitea accounts have multiple e-mails associated with them. We need combine those three above into one sum box as they all link to the same Gitea account. If you could take a look at that, I will continue with UI tweaks.

@sahinakkaya
Copy link
Contributor

sahinakkaya commented Nov 2, 2023

If you could take a look at that, I will continue with UI tweaks.

I would like to but I am not familiar with the code base that much. If you can tell me how can I find the Gitea account of a user via email address, I might try to fix it.

@silverwind silverwind closed this Nov 2, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/translation size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants