Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error toast when file size exceeds the limits #27985

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

lng2020
Copy link
Member

@lng2020 lng2020 commented Nov 10, 2023

As title.
Before that, there was no alert at all.
After:
error_toast

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 10, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 10, 2023
@lng2020 lng2020 added backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 labels Nov 10, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 10, 2023
@silverwind silverwind removed the backport/v1.20 This PR should be backported to Gitea 1.20 label Nov 10, 2023
@silverwind
Copy link
Member

Toasts are not in 1.20 so we can not backport there.

@silverwind
Copy link
Member

BTW I see we should make toasts fit to content width if it's small, I'll likely do a separate PR.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 10, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 10, 2023
@lunny lunny added this to the 1.22.0 milestone Nov 10, 2023
@lunny lunny merged commit 6c9e196 into go-gitea:main Nov 10, 2023
25 checks passed
@GiteaBot
Copy link
Contributor

@lng2020 please fix the merge conflicts. 🍵

@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 10, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 10, 2023
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 10, 2023
@delvh
Copy link
Member

delvh commented Nov 10, 2023

@GiteaBot?
You alright?
Why are you running the merge conflict check after the PR was merged?

lunny pushed a commit that referenced this pull request Nov 10, 2023
Backport #27985 by @lng2020

As title.
Before that, there was no alert at all.
After:

![error_toast](https://github.com/go-gitea/gitea/assets/70063547/c54ffeed-76f8-4c3a-b5dc-b9b3e0f8fc76)

Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
@lng2020 lng2020 deleted the show_err_toast branch November 12, 2023 11:29
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 13, 2023
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Fix wrong xorm Delete usage (go-gitea#27995)
  Move some JS code from `fomantic.js` to standalone files (go-gitea#27994)
  Fix the wrong oauth2 name (go-gitea#27993)
  Render email addresses as such if followed by punctuation (go-gitea#27987)
  Show error toast when file size exceeds the limits (go-gitea#27985)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants