Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing head of lfs client batch #28550

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 20, 2023

@lunny lunny requested a review from KN4CK3R December 20, 2023 10:53
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 20, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 20, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Dec 20, 2023

I'm wondering why this check does not fail without your change:

assert.Equal(t, MediaType, req.Header.Get("Accept"))

Isn't that the request you changed?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 20, 2023
@6543 6543 merged commit 5774216 into go-gitea:main Dec 20, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 20, 2023
@lunny lunny deleted the lunny/lfs_client branch December 20, 2023 11:58
@lunny
Copy link
Member Author

lunny commented Dec 20, 2023

@6543
Copy link
Member

6543 commented Dec 20, 2023

well I agree wit KN4CK3R, the test should catch this errors :D

zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 22, 2023
* giteaofficial/main:
  Add more ways to try (go-gitea#28581)
  Convert to url auth to header auth in tests (go-gitea#28484)
  Fix 500 error of searching commits (go-gitea#28576)
  improve possible performance bottleneck (go-gitea#28547)
  Use information from previous blame parts (go-gitea#28572)
  Make offline mode as default to no connect external avatar service by default (go-gitea#28548)
  Fix merging artifact chunks error when minio storage basepath is set (go-gitea#28555)
  feat: bump `dessant/lock-threads` and `actions/setup-go` to use nodejs20 runtime (go-gitea#28565)
  Update actions document about comparsion as Github Actions (go-gitea#28560)
  Fix inperformant query on retrifing review from database. (go-gitea#28552)
  Fix the issue ref rendering for wiki (go-gitea#28556)
  Add missing head of lfs client batch (go-gitea#28550)
  [skip ci] Updated translations via Crowdin
  Remove deadcode under models/issues (go-gitea#28536)
  Always enable caches (go-gitea#28527)
  Improve ObjectFormat interface (go-gitea#28496)
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Dec 23, 2023
@KN4CK3R KN4CK3R added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 23, 2023
lunny pushed a commit that referenced this pull request Dec 28, 2023
Revert #28550

Don't add the `Accept` header twice.
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
Revert go-gitea#28550

Don't add the `Accept` header twice.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
Revert go-gitea#28550

Don't add the `Accept` header twice.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants