-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import docs into main repository #2874
Conversation
Signed-off-by: Matti Ranta <matti@mdranta.net>
Codecov Report
@@ Coverage Diff @@
## master #2874 +/- ##
==========================================
- Coverage 32.53% 32.51% -0.02%
==========================================
Files 267 267
Lines 39270 39270
==========================================
- Hits 12776 12770 -6
- Misses 24700 24712 +12
+ Partials 1794 1788 -6
Continue to review full report at Codecov.
|
LGTM |
This would deprecate https://github.com/go-gitea/docs/ |
image: plugins/docker:17.05 | ||
pull: true | ||
secrets: [ docker_username, docker_password ] | ||
repo: gitea/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would still build a separate docker image just for docs that would push to https://hub.docker.com/r/gitea/docs/
See the next line where I specify the docker file found in the docs directory.
This would allow the docs on the gitea site to pull from the specific docs image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would these secrets prevent PRs from succeeding CI ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@strk good question. These secrets are already in use from the other docker container being built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then LGTM
LGTM |
@techknowlogick have you updated latest changes from docs? |
@lafriks I'm just missing the latest commit from 5 hours ago. Let me put that in and I'll ping you when that is done. Thanks for checking. |
@lafriks updated and drone has a successful build. |
@techknowlogick docs docker build fails with |
Looking at the drone-docker plugin it looks like it takes the main dir
as the folder instead of the dir that the dockerfile is in. I'm going to
submit a PR to resolve this now.
|
fixes docker build from: #2874
Fixes #2865 by merging docs repo and main gitea repo.
I've removed the following files from the docs subdir as they are the same as the contents in main repo:
but I've kept the LICENSE file as it differs from the one in the main repo.