Remove jQuery from organization rename prompt toggle #29195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switched to plain JavaScript - Tested the organization rename prompt toggling functionality and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
yardenshoham
added
the
type/refactoring
KN4CK3R
approved these changes
Feb 16, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Feb 16, 2024
wxiaoguang
approved these changes
Feb 16, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
pull-request-size
bot
added
size/S
wxiaoguang
reviewed
Feb 16, 2024
Comment on lines
+5
to
+6
| const orgNameInput = document.querySelector('.organization.settings.options #org_name'); | ||
| if (!orgNameInput) return; |
There was a problem hiding this comment.
Oh wait .... it seem incorrect .....
There is another call initCompLabelEdit below. It shouldn't return here.
So the old logic (like if ($('.organization').length === 0) { ) is still needed.
There was a problem hiding this comment.
Oh right, reverting.
wxiaoguang
removed
the
reviewed/wait-merge
GiteaBot
added
lgtm/need 1
This reverts commit 08b21e8.
pull-request-size
bot
added
size/XS
yardenshoham
force-pushed
the
common-organization-jquery
branch
from
84a8a3c
to
b7dcec6
Compare
pull-request-size
bot
added
size/XS
silverwind
reviewed
Feb 16, 2024
Co-authored-by: silverwind <me@silverwind.io>
silverwind
approved these changes
Feb 16, 2024
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
|
@yardenshoham please fix the merge conflicts. 🍵 |
GiteaBot
removed
the
reviewed/wait-merge
|
No, this is still not right. https://github.com/go-gitea/gitea/pull/29195/files#r1492567342 It shouldn't return there, there is another call below: @silverwind @yardenshoham it needs a following fix. |
|
Sorry, I thought that was handled, @yardenshoham please follow-up. |
|
I'm on it |
silverwind
pushed a commit
that referenced
this pull request
Feb 16, 2024
Fix broken `if` from #29195 Signed-off-by: Yarden Shoham <git@yardenshoham.com>
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Feb 19, 2024
Fix broken `if` from go-gitea/gitea#29195 Signed-off-by: Yarden Shoham <git@yardenshoham.com> (cherry picked from commit 2d8756a9607ee6029ad7a44985e9751988d5fdaa)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
- Switched to plain JavaScript - Tested the organization rename prompt toggling functionality and it works as before # Demo using JavaScript without jQuery  --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: silverwind <me@silverwind.io>
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Fix broken `if` from go-gitea#29195 Signed-off-by: Yarden Shoham <git@yardenshoham.com>
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
- Switched to plain JavaScript - Tested the organization rename prompt toggling functionality and it works as before # Demo using JavaScript without jQuery  --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: silverwind <me@silverwind.io> (cherry picked from commit 5902372)
|
Automatically locked because of our CONTRIBUTING guidelines |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo using JavaScript without jQuery