Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic error from #28138 #29417

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Fix logic error from #28138 #29417

merged 2 commits into from
Feb 26, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Feb 26, 2024 •
edited
Loading

There's a miss in #28138:
image

https://github.com/go-gitea/gitea/pull/28138/files#diff-2556e62ad7204a230c91927a3f2115e25a2b688240d0ee1de6d34f0277f37dfeR162

@lunny
Not sure about the impact of this, but it will only effect 1.22, and maybe we should fix it ASAP.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 26, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 26, 2024
@lunny lunny added this to the 1.22.0 milestone Feb 26, 2024
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 26, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2024
@KN4CK3R KN4CK3R enabled auto-merge (squash) February 26, 2024 07:44
@KN4CK3R KN4CK3R merged commit f8c1efe into go-gitea:main Feb 26, 2024
26 checks passed
@yp05327 yp05327 deleted the fix-bug-from-28138 branch February 26, 2024 08:42
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 27, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ddef710 
* giteaofficial/main:
  Fix mail template error (go-gitea#29410)
  Document our issue locking policy (go-gitea#29433)
  Fix htmx rendering the login page in frame on session logout (go-gitea#29405)
  Ignore empty repo for CreateRepository in action notifier (go-gitea#29416)
  Fix incorrect tree path value for patch editor (go-gitea#29377)
  Fix logic error from go-gitea#28138 (go-gitea#29417)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yp05327 @lunny @KN4CK3R @GiteaBot