Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API for Variables #29520

Merged
merged 25 commits into from
Mar 28, 2024
Merged

Add API for Variables #29520

merged 25 commits into from
Mar 28, 2024

Conversation

sillyguodong
Copy link
Contributor

close #27801

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2024
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Mar 1, 2024
lunny
lunny previously requested changes Mar 1, 2024
View reviewed changes
routers/api/v1/api.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 1, 2024
@lunny lunny dismissed their stale review March 1, 2024 14:06

It's still a draft

@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Mar 1, 2024
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2024
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 12, 2024
@sillyguodong sillyguodong added the topic/api Concerns mainly the API label Mar 12, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 13, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 26, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 28, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) March 28, 2024 18:51
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 28, 2024
@techknowlogick techknowlogick merged commit 62b073e into go-gitea:main Mar 28, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 28, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 28, 2024
@delvh
Copy link
Member

delvh commented Mar 28, 2024

So, this API will only be available on 1.23, right?

@silverwind
Copy link
Member

silverwind commented Mar 28, 2024 •
edited
Loading

I see release/v1.22 branch was created. So it would need to be backported but we don't have that bot label yet.

@delvh
Copy link
Member

delvh commented Mar 28, 2024

That's exactly why I'm asking:
Do we want to backport it, or not?

@silverwind
Copy link
Member

I would, it seems harmless.

@silverwind silverwind added the backport/v1.22 This PR should be backported to Gitea 1.22 label Mar 28, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 29, 2024
@sillyguodong @silverwind @GiteaBot
Add API for Variables (go-gitea#29520)
364ec73 
close go-gitea#27801

---------

Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot mentioned this pull request Mar 29, 2024
Closed
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Mar 29, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 29, 2024
@zjjhot
Merge remote-tracking branch 'upstream/main'
6b9952d 
* upstream/main:
  Remove fomantic checkbox module (go-gitea#30162)
  Refactor topic Find functions and add more tests for pagination (go-gitea#30127)
  replace jquery-minicolors with coloris (go-gitea#30055)
  Add API for `Variables` (go-gitea#29520)
  Fix `DEFAULT_SHOW_FULL_NAME=false` has no effect in commit list and commit graph page (go-gitea#30096)
  Fix migration v292 (go-gitea#30153)
  Adjust VS Code debug filename match in .gitignore (go-gitea#30158)
  Prevent re-review and dismiss review actions on closed and merged PRs (go-gitea#30065)
  Render code tags in commit messages (go-gitea#30146)
  Bump `@github/relative-time-element` to v4.4.0 (go-gitea#30154)
  Migrate font-family to tailwind (go-gitea#30118)
  Move from `max( id )` to `max( index )` for latest commit statuses (go-gitea#30076)
  Remember login for a month by default (go-gitea#30150)
@delvh delvh removed backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 labels Mar 29, 2024
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. topic/api Concerns mainly the API
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Add API for Act Runner's Variables Management
7 participants
@sillyguodong @lunny @silverwind @delvh @techknowlogick @wxiaoguang @GiteaBot