Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load attachments for code comments #30124

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Load attachments for code comments #30124

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2eb7aa0
fix
yp05327 Mar 27, 2024
6f7ca65
Merge branch 'main' into fix-30103
GiteaBot Mar 27, 2024
d645ea9
Merge branch 'main' into fix-30103
GiteaBot Mar 27, 2024
8fa2e7f
Merge branch 'main' into fix-30103
GiteaBot Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions models/issues/comment_code.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ func findCodeComments(ctx context.Context, opts FindCommentsOptions, issue *Issu
return nil, err
}

if err := comments.LoadAttachments(ctx); err != nil {
return nil, err
}

// Find all reviews by ReviewID
reviews := make(map[int64]*Review)
ids := make([]int64, 0, len(comments))
Expand Down