Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor startup deprecation messages #30305

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Refactor startup deprecation messages #30305

merged 3 commits into from
Apr 7, 2024

Conversation

wxiaoguang
Copy link
Contributor

It doesn't change logic, it only does:

  1. Rename the variable and function names
  2. Use more consistent format when mentioning config section&key
  3. Improve some messages

@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. backport/v1.22 This PR should be backported to Gitea 1.22 labels Apr 6, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 6, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 6, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Apr 6, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 6, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 6, 2024
@silverwind
Copy link
Member

silverwind commented Apr 6, 2024 •
edited
Loading

I do prefer the term "deprecation" instead of "startup problem". A setting deprecation is a subset of a startup problem: A changelog would list deprecations, not "startup problems".

@delvh
Copy link
Member

delvh commented Apr 6, 2024 •
edited
Loading

No, I think startup is more fitting here, since not only deprecation warnings can be reported there.
For example, we can report when your DB is misconfigured

@silverwind
Copy link
Member

No, I think startup is more fitting here, since not only deprecation warnings need to be reported there, for example when your DB is misconfigured

Can we still do deprecations after this PR and not being forced to name them "startup problems"?

@delvh
Copy link
Member

delvh commented Apr 6, 2024

I mean… a deprecation is a startup problem?

@silverwind
Copy link
Member

Yes, but would you write "we've added some startup problems" into a changelog? 😆 Anyways I think the functions are still named deprecateXXX so it's likely fine.

@wxiaoguang wxiaoguang enabled auto-merge (squash) April 7, 2024 00:09
@wxiaoguang
Copy link
Contributor Author

but would you write "we've added some startup problems" into a changelog?

"Gitea tries to detect some startup problems and show them in logs"

@wxiaoguang wxiaoguang merged commit bbe5cd7 into go-gitea:main Apr 7, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 7, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 7, 2024
@wxiaoguang @GiteaBot
Refactor startup deprecation messages (go-gitea#30305)
aec188a 
It doesn't change logic, it only does:

1. Rename the variable and function names
2. Use more consistent format when mentioning config section&key
3. Improve some messages
@GiteaBot GiteaBot mentioned this pull request Apr 7, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 7, 2024
@wxiaoguang wxiaoguang deleted the refactor-log-dep branch April 7, 2024 01:14
wxiaoguang added a commit that referenced this pull request Apr 7, 2024
@GiteaBot @wxiaoguang
Refactor startup deprecation messages (#30305) (#30312)
a29e505 
Backport #30305 by wxiaoguang

It doesn't change logic, it only does:

1. Rename the variable and function names
2. Use more consistent format when mentioning config section&key
3. Improve some messages

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 8, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
aa3428f 
* giteaofficial/main: (26 commits)
  Fix oauth2 builtin application logic (go-gitea#30304)
  [skip ci] Updated licenses and gitignores
  Some NuGet package enhancements (go-gitea#30280)
  Fix and rewrite contrast color calculation, fix project-related bugs (go-gitea#30237)
  Add `--page-spacing` variable, fix admin dashboard notice (go-gitea#30302)
  Action view mobile improvements and fixes (go-gitea#30309)
  Fix checkboxes on mobile view, remove some dead css (go-gitea#30308)
  Clean up log messages (go-gitea#30313)
  Fix right-aligned input icons (go-gitea#30301)
  Refactor startup deprecation messages (go-gitea#30305)
  [skip ci] Updated translations via Crowdin
  Remove fomantic list module (go-gitea#30281)
  Markup color and font size fixes (go-gitea#30282)
  Fix code block style for code preview (go-gitea#30298)
  Always use `octicon-eye` on watch button (go-gitea#30288)
  Fix view commit link (go-gitea#30297)
  Add gap to commit status details (go-gitea#30284)
  Update JS dependencies and add new eslint rules (go-gitea#30279)
  Upgrade `golang.org/x/net` to v0.24.0 (go-gitea#30283)
  Commit-Dropdown: Show Author of commit if available (go-gitea#30272)
  ...

# Conflicts:
#	templates/base/footer_content.tmpl
AvengerMoJo pushed a commit to AvengerMoJo/gitea that referenced this pull request Apr 8, 2024
@wxiaoguang @AvengerMoJo
Refactor startup deprecation messages (go-gitea#30305)
dab9586 
It doesn't change logic, it only does:

1. Rename the variable and function names
2. Use more consistent format when mentioning config section&key
3. Improve some messages
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @silverwind @delvh @lunny @GiteaBot