Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code owners will not be mentioned when a pull request comes from a forked repository #30476

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Fix code owners will not be mentioned when a pull request comes from a forked repository #30476

merged 3 commits into from
Apr 15, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 14, 2024

Fix #30277
Caused by #29783

@lunny lunny added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 labels Apr 14, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 14, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 14, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 14, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 15, 2024
yp05327
yp05327 approved these changes Apr 15, 2024
View reviewed changes
tests/integration/pull_review_test.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 15, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 15, 2024
@silverwind silverwind merged commit c63060b into go-gitea:main Apr 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 15, 2024
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.21. @lunny, please send one manually. 🍵

go run ./contrib/backport 30476
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 15, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 15, 2024
@lunny @GiteaBot
Fix code owners will not be mentioned when a pull request comes from …
e29d1ec 
…a forked repository (go-gitea#30476)

Fix go-gitea#30277
Caused by go-gitea#29783
@GiteaBot GiteaBot mentioned this pull request Apr 15, 2024
Merged
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 15, 2024
@lunny lunny deleted the lunny/fix_codeowner_from_forked branch April 15, 2024 14:49
lunny added a commit to lunny/gitea that referenced this pull request Apr 15, 2024
@lunny
Fix code owners will not be mentioned when a pull request comes from …
da35d93 
…a forked repository (go-gitea#30476)

Fix go-gitea#30277
Caused by go-gitea#29783
@lunny lunny mentioned this pull request Apr 15, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Apr 15, 2024
silverwind pushed a commit that referenced this pull request Apr 15, 2024
@GiteaBot @lunny
Fix code owners will not be mentioned when a pull request comes from …
3d31b59 
…a forked repository (#30476) (#30496)

Backport #30476 by @lunny

Fix #30277
Caused by #29783

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny added a commit that referenced this pull request Apr 16, 2024
@lunny
Fix code owners will not be mentioned when a pull request comes from …
60181eb 
…a forked repository (#30476) (#30497)

Backport #30476 
Fix #30277
Caused by #29783
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9c37592 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix various overflows on actions view (go-gitea#30344)
  Convert max file name length to 255 (go-gitea#30489)
  Remove active border on pointing menu (go-gitea#30486)
  Fix button color on red and green buttons (go-gitea#30500)
  Fix code owners will not be mentioned when a pull request comes from a forked repository (go-gitea#30476)
  Fix overflow on issue dependency (go-gitea#30484)
  Kill all gitea processes before air build (go-gitea#30477)
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh left review comments

@yp05327 yp05327 yp05327 approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Gitea does not apply CODEOWNERS for PRs from forks
7 participants
@lunny @GiteaBot @wolfogre @yp05327 @delvh @silverwind @wxiaoguang