Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right align the "Settings" menu item in overflow-menu #30764

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Right align the "Settings" menu item in overflow-menu #30764

merged 4 commits into from
Apr 30, 2024

Conversation

wxiaoguang
Copy link
Contributor

I guess there could be enough people liking to make the Settings menu item right aligned. As a site admin, I found it's easier to find the right-aligned Settings menu item.

Tested with various sizes:

image

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 29, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 29, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/js labels Apr 29, 2024
@wxiaoguang
Copy link
Contributor Author

One more question, would we like to backport this as a usability fix? To make 1.22 match the UI in 1.21

@wxiaoguang wxiaoguang added the backport/v1.22 This PR should be backported to Gitea 1.22 label Apr 29, 2024
@silverwind
Copy link
Member

I don't care, I'm happy with it left-aligned too and that matches GitHub.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 29, 2024
@silverwind
Copy link
Member

silverwind commented Apr 29, 2024 •
edited
Loading

Tested it, there is a minor issue around the window size where the breakpoint kicks in that lowers the page margin and the menu item hides, show and hide again there while slowly downsizing the window. The old code also had this issue, but not as severe as I'm seeing it here.

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Apr 30, 2024 •
edited
Loading

Tested it, there is a minor issue around the window size where the breakpoint kicks in that lowers the page margin and the menu item hides, show and hide again there while slowly downsizing the window. The old code also had this issue, but not as severe as I'm seeing it here.

Yup, I also have noticed it, I think it is caused by the container's width differs for different screen widths. If you'd like to fix it together: cd2324e

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 30, 2024
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 30, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 30, 2024
@lunny lunny enabled auto-merge (squash) April 30, 2024 04:20
@lunny lunny merged commit 059b271 into go-gitea:main Apr 30, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 30, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 30, 2024
@wxiaoguang @GiteaBot
Right align the "Settings" menu item in overflow-menu (go-gitea#30764)
c0a3d53 
I guess there could be enough people liking to make the Settings menu
item right aligned. As a site admin, I found it's easier to find the
right-aligned Settings menu item.

Tested with various sizes:

![image](https://github.com/go-gitea/gitea/assets/2114189/92836527-2cb2-4531-9296-233c5bd698f4)

![image](https://github.com/go-gitea/gitea/assets/2114189/3a0729fc-5e33-44b5-9fb4-3a4e787405b5)

![image](https://github.com/go-gitea/gitea/assets/2114189/9845ab6b-88e3-4e5a-8d6d-2b8af259d593)
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 30, 2024
@GiteaBot GiteaBot mentioned this pull request Apr 30, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 30, 2024
@wxiaoguang wxiaoguang deleted the fix-menu-right branch April 30, 2024 04:28
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 30, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
316e61b 
* giteaofficial/main:
  Right align the "Settings" menu item in overflow-menu (go-gitea#30764)
wxiaoguang added a commit that referenced this pull request Apr 30, 2024
@GiteaBot @wxiaoguang
Right align the "Settings" menu item in overflow-menu (#30764) (#30777)
6ee3a8a 
Backport #30764 by wxiaoguang

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@silverwind
Copy link
Member

Tested it, there is a minor issue around the window size where the breakpoint kicks in that lowers the page margin and the menu item hides, show and hide again there while slowly downsizing the window. The old code also had this issue, but not as severe as I'm seeing it here.

Yup, I also have noticed it, I think it is caused by the container's width differs for different screen widths. If you'd like to fix it together: cd2324e

Hmm not sure about that removal. The idea is to have differently sized margins depending on viewport width, hopefully that still works after this.

@wxiaoguang
Copy link
Contributor Author

Hmm not sure about that removal. The idea is to have differently sized margins depending on viewport width, hopefully that still works after this.

The default .ui.container already has width + max-width, it works well for different screen widths, and it is better than the old hard-coded widths.

silverwind added a commit to silverwind/gitea that referenced this pull request Apr 30, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into btnrow
3ec0b96 
* origin/main: (55 commits)
  Fix dashboard commit status null access (go-gitea#30771)
  Fix tautological conditions (go-gitea#30735)
  Get repo assignees and reviewers should ignore deactivated users (go-gitea#30770)
  Right align the "Settings" menu item in overflow-menu (go-gitea#30764)
  Fix duplicate status check contexts (go-gitea#30660)
  Fix issue label rendering in the issue popup (go-gitea#30763)
  Fix all rounded borders, change affected tab menus to pills (go-gitea#30707)
  Rename CodeIndexerEnabled to IsRepoIndexerEnabled (go-gitea#30762)
  Remove fomantic dimmer module (go-gitea#30723)
  Resolve lint for unused parameter and unnecessary type arguments (go-gitea#30750)
  Add support for npm bundleDependencies (go-gitea#30751)
  Fix cross-compilation errors when CGO_CFLAGS/CGO_LDFLAGS is set (go-gitea#30749)
  [skip ci] Updated licenses and gitignores
  add built js files to eslint ignore (go-gitea#30737)
  Gitea with first upper case + typos (go-gitea#30739)
  Fix documentation build problems because of MDX syntax conflicts (go-gitea#30744)
  Remove disk-clean workflow (go-gitea#30741)
  Bump `github.com/google/go-github` to v61 (go-gitea#30738)
  Fix nil dereference on error (go-gitea#30740)
  Use `ProtonMail/go-crypto` for `opengpg` in tests (go-gitea#30736)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind left review comments

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @silverwind @lunny @delvh @GiteaBot