Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Sort repo list on dashboard alphabetically #30772

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP] Sort repo list on dashboard alphabetically #30772

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71ff656
Use alphabetic sort for repo list at Dashboard
6543 Apr 30, 2024
161a97a
RepoOrderBy-respect-owner-too
6543 Apr 30, 2024
e0ee13e
sort alpha asc
6543 Apr 30, 2024
411bfe0
Merge branch 'main' into upstream_sort-repo-list-on-dashboard
6543 May 7, 2024
d0e6962
Merge branch 'main' into upstream_sort-repo-list-on-dashboard
6543 Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web_src/js/components/DashboardRepoList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const sfc = {
return this.repos.length > 0 && this.repos.length < this.counts[`${this.reposFilter}:${this.archivedFilter}:${this.privateFilter}`];
},
searchURL() {
return `${this.subUrl}/repo/search?sort=updated&order=desc&uid=${this.uid}&team_id=${this.teamId}&q=${this.searchQuery
return `${this.subUrl}/repo/search?sort=alpha&order=asc&uid=${this.uid}&team_id=${this.teamId}&q=${this.searchQuery
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be configurable? Sorting by updated time is helpful to me. I usually work on a fixed number of repos at a time, and having them at the top is helpful. The first few repos sorted alphabetically may not be active.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm also not sure about alphabetic sorting here:
I've gotten used to seeing my current repos there as well on the first page to navigate to them quickly.
I don't think it's a good idea to require alphabetic sorting here by default.

}&page=${this.page}&limit=${this.searchLimit}&mode=${this.repoTypes[this.reposFilter].searchMode
}${this.archivedFilter === 'archived' ? '&archived=true' : ''}${this.archivedFilter === 'unarchived' ? '&archived=false' : ''
}${this.privateFilter === 'private' ? '&is_private=true' : ''}${this.privateFilter === 'public' ? '&is_private=false' : ''
Expand Down