-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not show monaco JS errors #30862
Merged
Merged
Do not show monaco JS errors #30862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
May 5, 2024
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
May 5, 2024
lunny
approved these changes
May 5, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
May 5, 2024
wxiaoguang
force-pushed
the
fix-monaco-editor-err
branch
from
May 5, 2024 10:23
11b6e7b
to
219619c
Compare
pull-request-size
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
May 5, 2024
KN4CK3R
reviewed
May 5, 2024
KN4CK3R
approved these changes
May 5, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
May 5, 2024
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 5, 2024
wxiaoguang
added a commit
that referenced
this pull request
May 5, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 6, 2024
* giteaofficial/main: Have time.js use UTC-related getters/setters (go-gitea#30857) Do not show monaco JS errors (go-gitea#30862) Fix issue/PR title edit (go-gitea#30858) Add result check in TestAPIEditUser (go-gitea#29674)
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
May 19, 2024
Fix #3638 This is a manual Forgejo-specific version of the Gitea PR go-gitea/gitea#30862. The weekly Forgejo PR #3772 could not cherry-pick this commit due to conflicts (eg subsequent CodeSpell changes). Only occurs with Webkit in Safari over eg `http://192..`. (not localhost). See https://webkit.org/blog/10855/async-clipboard-api/ --- **Before** ![Before.jpg](/attachments/c570d030-fcce-48ea-ac96-06b624541c7b) **After** ![After.jpg](/attachments/1a9132ab-f7f3-43a5-b3ea-37b6f2b671c4) Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3805 Reviewed-by: Otto <otto@codeberg.org> Co-authored-by: David Davies-Payne <d2p@me.com> Co-committed-by: David Davies-Payne <d2p@me.com>
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
May 19, 2024
Fix #3638 This is a manual Forgejo-specific version of the Gitea PR go-gitea/gitea#30862. The weekly Forgejo PR #3772 could not cherry-pick this commit due to conflicts (eg subsequent CodeSpell changes). Only occurs with Webkit in Safari over eg `http://192..`. (not localhost). See https://webkit.org/blog/10855/async-clipboard-api/ --- **Before** ![Before.jpg](/attachments/c570d030-fcce-48ea-ac96-06b624541c7b) **After** ![After.jpg](/attachments/1a9132ab-f7f3-43a5-b3ea-37b6f2b671c4) Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3805 Reviewed-by: Otto <otto@codeberg.org> Co-authored-by: David Davies-Payne <d2p@me.com> Co-committed-by: David Davies-Payne <d2p@me.com> (cherry picked from commit e4c3c03)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
backport/v1.22
This PR should be backported to Gitea 1.22
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/js
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30861