Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix incorrect init order #31031

Closed
wants to merge 1 commit into from
Closed

WIP: Fix incorrect init order #31031

wants to merge 1 commit into from

Conversation

wxiaoguang
Copy link
Contributor

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 20, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 20, 2024
@wxiaoguang wxiaoguang added type/bug and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2024
@wxiaoguang wxiaoguang marked this pull request as draft May 20, 2024 16:33
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 20, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 20, 2024
@wxiaoguang
Copy link
Contributor Author

Still WIP because the problem seems more complex than I thought. Maybe will try to figure out a better solution in 1.23

@wxiaoguang wxiaoguang added the pr/wip This PR is not ready for review label May 21, 2024
@wxiaoguang wxiaoguang changed the title Fix incorrect init order WIP: Fix incorrect init order May 21, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 21, 2024
@wxiaoguang wxiaoguang closed this Jul 17, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/go Pull requests that update Go code pr/wip This PR is not ready for review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wxiaoguang @delvh @GiteaBot