Fix hash render end with colon #31319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
appleboy
approved these changes
Jun 11, 2024
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Jun 11, 2024
GiteaBot
added
lgtm/done
delvh
reviewed
Jun 11, 2024
| @@ -49,7 +49,7 @@ var ( | |||
| // hashCurrentPattern matches string that represents a commit SHA, e.g. d8a994ef243349f321568f9e36d5c3f444b99cae | |||
| // Although SHA1 hashes are 40 chars long, SHA256 are 64, the regex matches the hash from 7 to 64 chars in length | |||
| // so that abbreviated hash links can be used as well. This matches git and GitHub usability. | |||
| hashCurrentPattern = regexp.MustCompile(`(?:\s|^|\(|\[)([0-9a-f]{7,64})(?:\s|$|\)|\]|[.,](\s|$))`) | |||
| hashCurrentPattern = regexp.MustCompile(`(?:\s|^|\(|\[)([0-9a-f]{7,64})(?:\s|$|\)|\]|[.,:](\s|$))`) | |||
There was a problem hiding this comment.
By the way, why aren't we using \b here?
I think that would simplify things…
There was a problem hiding this comment.
Looks like yes. Maybe I should change to \b?
There was a problem hiding this comment.
Try it and see if the existing test cases work.
There was a problem hiding this comment.
Maybe it can be tried by another PR since this one is a quick patch.
silverwind
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 12, 2024
Fix a hash render problem like `<hash>: xxxxx` which is usually used in release notes.
GiteaBot
added
backport/done
lunny
added a commit
that referenced
this pull request
Jun 13, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 13, 2024
* giteaofficial/main: Fixed incorrect localization `explorer.go` (go-gitea#31348) Improve detecting empty files (go-gitea#31332) Fix hash render end with colon (go-gitea#31319) Fix line number widths (go-gitea#31341) Fix navbar `+` menu flashing on page load (go-gitea#31281) Reduce memory usage for chunked artifact uploads to MinIO (go-gitea#31325) Fix dates displaying in a wrong manner when we're close to the end of the month (go-gitea#31331) Fix adopt repository has empty object name in database (go-gitea#31333) Optimize profile layout to enhance visual experience (go-gitea#31278)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a hash render problem like
<hash>: xxxxxwhich is usually used in release notes.