Fix Workflow names instead of workflow file name

[kiatt210]

Fixes #31458 and maybe #25912

I added the name from the YAML file to the workflow object. If there is no name in the file, the name remains the filename.
I created an object to connect the run and workflow together, which was necessary to show workflow name in action run list.

(Easier to review with disabled whitespace changes, unfortunately there is a lot of them in runs_list.tmpl :( )

[wxiaoguang]

The variable shadowing is more complex now. And the name Run also seems ambiguous

I think it's better to do so:

{{range $run = .WorkflowActionRuns}}
    {{$actionRun := $run.ActionRun}}
    {{$workflow = $run.Workflow}}
    {{$actionRun.Title}}
    ...

[kiatt210]

Thanks for the idea, I did the changes.

[kemzeb]

LGTM!

[silverwind]

If there is no name in the file, the name remains the filename.

I tested in GitHub actions and they show the full path to the file when workflow name is absent, e.g. .github/workflows/ci2.yaml. Might be especially relevant to us because we look into both .github and .gitea folders so filename alone can be ambigous.

[yp05327]

IIRC, GitHub has some bugs of display workflow name. That’s why no one fix this issue for a long time I think.
I have no time the check the code, as this is approved too quickly, so I’m not sure whether this PR can handle some special cases which GitHub can not.

[kiatt210]

Do you have any idea which special cases I should check or where I should look for them?
Thank you!

[yp05327]

I still remember the details of one test I did. And I tested it in this PR. The result is as my thought.

For example, you have 2 branches, and the workflow files have same file name, but the workflow names are different.
Then the result is this:

In the list, the workflow name is Gitea Actions Demo which is defined in the main branch:

But in test branch, the workflow name is Gitea Actions Demo in test:

But they are all detected as the workflow Gitea Actions Demo.

So actually, the logic is still based on the file name, not the workflow name defined in the yml file.
That's why we are using file name but not workflow name here.

IIRC, this is caused by the original design of Gitea Action, if we want to use workflow names instead of file names,
we need to rewrite many places.

[delvh]

as per @yp05327, we should probably iron out edge cases first

stale

[wxiaoguang]

Stale for long time