Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code from models/repos/release.go #31756

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Remove unused code from models/repos/release.go #31756

merged 2 commits into from
Aug 2, 2024

Conversation

kemzeb
Copy link
Contributor

@kemzeb kemzeb commented Aug 1, 2024

These blocks aren't used anywhere else when doing a grep search.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 1, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 1, 2024
@kemzeb kemzeb changed the title Remove unused code from web/repos/release.go Remove unused code from models/repos/release.go Aug 1, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 1, 2024
@kemzeb
Remove unused code from models/repos/release.go
e62e6ce 
These blocks aren't used anywhere else when doing a grep search.
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 1, 2024
a1012112796
a1012112796 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@a1012112796 a1012112796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, a litle wonder why lint tools can't found it?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 2, 2024
@lunny lunny enabled auto-merge (squash) August 2, 2024 13:54
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 2, 2024
@lunny lunny merged commit 0e3d8f8 into go-gitea:main Aug 2, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Aug 2, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 2, 2024
@kemzeb kemzeb deleted the refactor-models-release branch August 2, 2024 14:29
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 5, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bba3608 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Rename head branch of pull requests when renaming a branch (go-gitea#31759)
  [skip ci] Updated translations via Crowdin
  Fix wiki revision pagination (go-gitea#31760)
  [skip ci] Updated translations via Crowdin
  Update JS dependencies (go-gitea#31766)
  Upgrade bleve to 2.4.2 (go-gitea#31762)
  Remove unused code from models/repos/release.go (go-gitea#31756)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@kemzeb @lunny @a1012112796 @delvh @GiteaBot