-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix markdown commit link generation #4545
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4545 +/- ##
=========================================
- Coverage 37.41% 37.4% -0.01%
=========================================
Files 306 306
Lines 45374 45374
=========================================
- Hits 16975 16972 -3
- Misses 25946 25948 +2
- Partials 2453 2454 +1
Continue to review full report at Codecov.
|
Will this not break relative url generation? |
No It doesn't... I have tested it but another person can make sure to verify though |
Has anyone tested this yet ? |
I have now build and tested it. It seems to successfully fix the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does break images (that are in same repository) and links to other repository files
For example:
![deadline.png](deadline.png)
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
@adelowo ping |
The problem In the title was actually fixed a different way in #6645 |
Closed per above comment. |
Fixes #4536