Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix markdown commit link generation #4545

Closed
wants to merge 9 commits into from

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jul 29, 2018

Fixes #4536

@codecov-io
Copy link

codecov-io commented Jul 29, 2018

Codecov Report

Merging #4545 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4545      +/-   ##
=========================================
- Coverage   37.41%   37.4%   -0.01%     
=========================================
  Files         306     306              
  Lines       45374   45374              
=========================================
- Hits        16975   16972       -3     
- Misses      25946   25948       +2     
- Partials     2453    2454       +1
Impacted Files Coverage Δ
routers/repo/view.go 45.06% <100%> (ø) ⬆️
modules/markup/html.go 88.88% <0%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb3954f...b7d2590. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 29, 2018
@lafriks
Copy link
Member

lafriks commented Jul 29, 2018

Will this not break relative url generation?

@adelowo
Copy link
Member Author

adelowo commented Jul 29, 2018

No It doesn't... I have tested it but another person can make sure to verify though

@lunny lunny added the type/bug label Jul 30, 2018
@adelowo
Copy link
Member Author

adelowo commented Aug 21, 2018

Has anyone tested this yet ?

@krombel
Copy link

krombel commented Aug 22, 2018

I have now build and tested it. It seems to successfully fix the issue

@lunny lunny modified the milestones: 1.5.1, 1.6.0 Aug 24, 2018
@techknowlogick techknowlogick modified the milestones: 1.6.0, 1.7.0 Sep 3, 2018
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does break images (that are in same repository) and links to other repository files

For example:

![deadline.png](deadline.png)

@adelowo
Copy link
Member Author

adelowo commented Sep 18, 2018

Thanks for the update @lafriks .... Would verify that and fix

Update

@lafriks , You are right... Once the 1.7.0 cycle opens, would resolve it

@lafriks lafriks modified the milestones: 1.7.0, 1.8.0 Dec 27, 2018
@techknowlogick techknowlogick modified the milestones: 1.8.0, 1.9.0 Feb 19, 2019
@stale
Copy link

stale bot commented Apr 20, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 20, 2019
@lafriks
Copy link
Member

lafriks commented Apr 20, 2019

@adelowo ping

@stale stale bot removed the issue/stale label Apr 20, 2019
@mrsdizzie
Copy link
Member

The problem In the title was actually fixed a different way in #6645

@techknowlogick
Copy link
Member

Closed per above comment.

@techknowlogick techknowlogick removed this from the 1.9.0 milestone Apr 21, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Link when referencing a commit hash on README.md
8 participants