Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SUBJECT_PREFIX mailer config option #6605

Merged
merged 4 commits into from Apr 17, 2019

Conversation

6 participants
@zeripath
Copy link
Contributor

commented Apr 13, 2019

Since the split Gogs has added a SUBJECT_PREFIX option to the mailer config. This PR implements this option.

Fix #6574

@zeripath zeripath added this to the 1.9.0 milestone Apr 13, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 13, 2019

Codecov Report

Merging #6605 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6605      +/-   ##
==========================================
- Coverage   40.55%   40.55%   -0.01%     
==========================================
  Files         406      406              
  Lines       54501    54506       +5     
==========================================
+ Hits        22102    22104       +2     
  Misses      29364    29364              
- Partials     3035     3038       +3
Impacted Files Coverage Δ
modules/setting/mailer.go 50.7% <100%> (+0.7%) ⬆️
modules/mailer/mailer.go 22.51% <40%> (+0.05%) ⬆️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fd242...f9d8287. Read the comment docs.

Show resolved Hide resolved custom/conf/app.ini.sample

zeripath added some commits Apr 16, 2019

Add space between subject prefix and subject (Change from Gogs)
Signed-off-by: Andrew Thornton <art27@cantab.net>

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 16, 2019

@techknowlogick techknowlogick requested a review from lunny Apr 17, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 17, 2019

@lunny

lunny approved these changes Apr 17, 2019

@techknowlogick techknowlogick merged commit 827ab6b into go-gitea:master Apr 17, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@zeripath zeripath deleted the zeripath:fix-6574-Subject-Prefix branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.