Stop colorizing log files by default #6949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6949 +/- ##
=========================================
Coverage ? 41.48%
=========================================
Files ? 441
Lines ? 59662
Branches ? 0
=========================================
Hits ? 24750
Misses ? 31689
Partials ? 3223
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
mrsdizzie
approved these changes
May 14, 2019
GiteaBot
added
lgtm/need 1
lunny
requested changes
May 15, 2019
| @@ -113,7 +112,6 @@ func generateLogConfig(sec *ini.Section, name string, defaults defaultLogOptions | |||
| panic(err.Error()) | |||
| } | |||
|
|
|||
| logConfig["colorize"] = sec.Key("COLORIZE").MustBool(runtime.GOOS != "windows") | |||
There was a problem hiding this comment.
So file logs always have no colorize?
There was a problem hiding this comment.
Nope it falls through to:
So it just defaults to false
lunny
approved these changes
May 15, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6942