Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track labels changed on issue view & resolved #542 #788

Merged
merged 2 commits into from
Jan 30, 2017
Merged

Track labels changed on issue view & resolved #542 #788

merged 2 commits into from
Jan 30, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 29, 2017

See the screenshot.
untitled

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 29, 2017
@lunny lunny added this to the 1.1.0 milestone Jan 29, 2017
@strk
Copy link
Member

strk commented Jan 29, 2017

LGTM, great new features this 1.1.0 :)

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2017
bkcsoft
bkcsoft reviewed Jan 29, 2017
View reviewed changes
Copy link
Member

@bkcsoft bkcsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 🙂

models/issue.go
}

var toAdd, toRemove []*Label
for _, l := range labels {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should Sort these first? should make it slightly faster in some cases 🙂

models/issue.go
}
}

for _, oriLabel := range issue.Labels {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

appleboy
appleboy suggested changes Jan 30, 2017
View reviewed changes
routers/repo/issue_label.go
@@ -0,0 +1,166 @@
package repo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Copyright.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@bkcsoft
Copy link
Member

bkcsoft commented Jan 30, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 30, 2017
@lunny
Copy link
Member Author

lunny commented Jan 30, 2017

let L-G-T-M work

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2017
@lunny lunny merged commit f94869d into go-gitea:master Jan 30, 2017
@lunny lunny deleted the lunny/track_tag_changes branch January 30, 2017 12:46
lunny added a commit to lunny/gitea that referenced this pull request Jan 30, 2017
@lunny
fix bug caused by go-gitea#788
a15dd38
lunny added a commit that referenced this pull request Jan 30, 2017
@lunny
fix bug caused by #788 (#799)
77ab60d
@jeppech jeppech mentioned this pull request Feb 3, 2017
Closed
@lunny
Copy link
Member Author

lunny commented Feb 5, 2017

resolved #789

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkcsoft bkcsoft bkcsoft left review comments

@appleboy appleboy appleboy requested changes

@avelino avelino avelino approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lunny @strk @bkcsoft @appleboy @avelino @metalmatze @tboerger