-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement documentation search #8937
Conversation
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8937 +/- ##
==========================================
+ Coverage 41.22% 41.27% +0.05%
==========================================
Files 547 546 -1
Lines 70764 71005 +241
==========================================
+ Hits 29173 29308 +135
- Misses 37870 37979 +109
+ Partials 3721 3718 -3
Continue to review full report at Codecov.
|
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
Currently docs page already uses CDN for font awesome so regardless I don't think that discussion needs to block this PR |
This uses a gist linked from the Hugo documentation for adding a search to your site.
I chose this method because it doesn't require any other build steps, just
hugo
.It combines a few of the changes made by comments as well, such as forgoing jQuery so as to not add a dependency to it.
I added a few other languages based on indexes we have available. I admittedly just translated with Google, so feel free to correct them if it butchered them too badly.
I also moved the
Help
side-item to the top so it is more prominent.I do not consider myself a UI or JS expert, so feel free to add corrections if you feel they are necessary.