Don't convert ellipsis in markdown #9905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
lafriks
approved these changes
Jan 21, 2020
GiteaBot
added
the
lgtm/need 1
guillep2k
approved these changes
Jan 21, 2020
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #9905 +/- ##
==========================================
- Coverage 42.3% 42.28% -0.02%
==========================================
Files 607 608 +1
Lines 79353 79393 +40
==========================================
+ Hits 33571 33574 +3
- Misses 41640 41677 +37
Partials 4142 4142
Continue to review full report at Codecov.
|
zeripath
reviewed
Jan 21, 2020
zeripath
reviewed
Jan 21, 2020
Co-Authored-By: zeripath <art27@cantab.net>
|
Is it the proper fix, though? I mean the bug is not in the ellipsis convertion per se, but rather that ellipsises are converted inside autolinked URLs as well. Maybe that's the only thing we can do for the time being, but I think this warrants creating an upstream bug as well. |
|
It's not upstream's fault - it's ours. Really we should run this filter after we've detected all the urls - but we do that outside of the markdown renderer. What we need to do is do the link detection from within markdown and only run our link detection on html files. |
|
@jolheiser Please send backport. |
jolheiser
added a commit
to jolheiser/gitea
that referenced
this pull request
Jan 22, 2020
* Don't convert ellipsis Signed-off-by: jolheiser <john.olheiser@gmail.com> * Formatting Co-Authored-By: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com> Co-authored-by: zeripath <art27@cantab.net>
techknowlogick
added
the
backport/done
zeripath
added a commit
that referenced
this pull request
Jan 22, 2020
* Don't convert ellipsis Signed-off-by: jolheiser <john.olheiser@gmail.com> * Formatting Co-Authored-By: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com> Co-authored-by: zeripath <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9904