This repository has been archived by the owner on May 24, 2019. It is now read-only.
add --asset flag to tea releases create
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urfave/cli does not provide arguments to parent commands to their children, so in order for subcommands to work, we have to check both ctx.GlobalString and ctx.String for values to be present.
allows to specify a file path to be attached to the release. can be specified multiple times
lafriks
suggested changes
Dec 4, 2018
|
@lafriks i resolved your change requests, any updates on this? |
|
Any news on this? Would be nice to have. |
lafriks
approved these changes
Mar 9, 2019
lunny
suggested changes
Mar 11, 2019
lafriks
suggested changes
Mar 11, 2019
lunny
approved these changes
Mar 11, 2019
lafriks
suggested changes
Mar 11, 2019
Co-Authored-By: noerw <noerw@users.noreply.github.com>
lafriks
approved these changes
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4:
Adds the
--assetflag (-ashorthand) totea releases create, allowing to specify a file by path to be attached to the release.hub-releasecommandAlso fixes the execution of subcommands, which failed because the parent command arguments (repository + login) where not recognized.