Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $PATH/glow requirement for running go generate #158

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

myaaaaaaaaa
Copy link
Contributor

Switches to running glow via go run ../glow/, which makes it easier to sync changes between the two repositories.

@hajimehoshi
Copy link
Member

LGTM (but I'd like to wait for other reviewers)

Copy link
Member

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/CC @dmitshur

generate.go Outdated Show resolved Hide resolved
Copy link
Member

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this is an improvement. Thanks.

generate.go Outdated Show resolved Hide resolved
@hajimehoshi hajimehoshi merged commit 07e5d0e into go-gl:master Oct 21, 2023
12 checks passed
@myaaaaaaaaa myaaaaaaaaa deleted the generate-glow branch October 21, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants