Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
3.3 beta - don't merge yet #219
Got rid of internal error callback. Never liked the way we solved it back then. It was not idiomatic and it was not mirroring the C API (worst of both worlds?). Now we have glfwGetError() function along with callback setting ability. It's still not idiomatic (only way to do it idiomatically is to return errors from all functions) but at least it mirrors the C API now. As always I'm open to suggestions. Any opinions?
I've also noticed that the 2 joystick functions we have were accepting the joystick IDs as arguments whereas we could have made it receivers. As our aim is to make the library as idiomatic as possible I've changed it. With 3.3 we have many more joystick functions so I think it looks better now. What do you think?
As a side note, I see no reason to implement the Vulkan functions. Thanks to Window.Handle() vulkan-go packages can access the GLFW window handle and create the necessary surface. So as is, it's ready for Vulkan.
README.md has the changelog as always, if you want to see the details.
Looks complete now according to this: http://www.glfw.org/docs/3.3/news.html
@tapir On OSX 10.14 with
Has MoltenVK become a mandatory dependency?
What about the other errors in native_darwin.c?
I understand that GL is deprecated. But Elmindreda told me on IRC that GLFW could also be used with Metal and that GL will continue to work on OSX even if they are not going to add newer versions and that a few things will break.
go-gl/glfw/v3.2 is go getable without the need to install any additional library on the system.
Molten is not yet something that one can easily install on OSX, there are no brew packages.
Indeed it can. I'm currently using GLFW v3.2 on macOS with Metal here.
Sure, I'll help with the macOS side of things. I don't know when I'll have free time, but I'll try to get to it.
referenced this pull request
Nov 7, 2018
Has anyone managed to get this pull request running on MacOS?
Now that with Mojave GLFW 3.2 is no longer running, I decided to give the GLFW 3.3 (be it unstable) a try. I am hitting the same problem as @kivutar :
# github.com/go-gl/glfw/v3.3/glfw ld: framework not found MoltenVK clang: error: linker command failed with exit code 1 (use -v to see invocation) # github.com/go-gl/glfw/v3.3/glfw native_darwin.c:7:17: warning: implicit declaration of function 'glfwGetCocoaWindow' is invalid in C99 [-Wimplicit-function-declaration] native_darwin.c:7:9: warning: cast to 'void *' from smaller integer type 'int' [-Wint-to-void-pointer-cast] native_darwin.c:11:17: warning: implicit declaration of function 'glfwGetNSGLContext' is invalid in C99 [-Wimplicit-function-declaration] native_darwin.c:11:9: warning: cast to 'void *' from smaller integer type 'int' [-Wint-to-void-pointer-cast]
I downloaded Vulkan SDK and put the