Add -version flag for carbonapi executable #866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
whilst testing carbonapi I was noticing there was no
version
flag. This PR implements this flag similar to go-carbon.I think it would also make sense to add more context to the output, meaning what the two lines mean:
But, I went for consistency with go-carbon. Alternatively, I could add the suggestion here and also open a PR in the go-carbon repo.
Regards,
Markus