Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Improve Error Message For Unknown Aggregation Method Error #422

Closed
SJrX opened this issue Aug 7, 2021 · 0 comments
Closed

[FR] Improve Error Message For Unknown Aggregation Method Error #422

SJrX opened this issue Aug 7, 2021 · 0 comments

Comments

@SJrX
Copy link

SJrX commented Aug 7, 2021

Is your feature request related to a problem? Please describe.
I was switching over to go-carbon and had a typo in my storage-aggregation.conf file, I had aggergationMethod instead of aggregationMethod. This had kind of worked fine with the python version. However when I started up go-carbon I just got an error that said "unknown aggregation method ''", which made no sense to me.

I "knew" the file worked with carbon, so I thought it was a bug, but had to clone the repo and run it with debugging to debug.

Describe the solution you'd like
A slightly better error message

Additional context
I guess in other cases line numbers would be useful, but that didn't seem like an easy refactor in the code.

@deniszh deniszh closed this as completed in ba841f8 Aug 8, 2021
deniszh added a commit that referenced this issue Aug 8, 2021
Resolves #422 - Include section name when unknown aggregation method …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant