Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: upgrade to go 1.16 and drops SOURCES from Makefile #417

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

bom-d-van
Copy link
Member

  • The SOURCES list slows down make file due to listing 20k go files when upgrade to 1.16.
    Does not seem a necessary when using go build.
  • Specify build -mod=vedor.
  • Upgrade go version to 1.16.

* The SOURCES list slows down make file due to listing 20k go files when upgrade to 1.16.
  Does not seem a necessary when using go build.
* Specify build -mod=vedor.
* Upgrade go version to 1.16.
@bom-d-van
Copy link
Member Author

Hi @deniszh @Civil , I'm merging this changes. It should be a mostly harmless changes and it seems tests are passed.

If there are problems, we can revert or patch it.

@bom-d-van bom-d-van merged commit 8356eb9 into master Jul 19, 2021
@bom-d-van bom-d-van deleted the go/upgrade-to-1.16 branch July 19, 2021 13:31
@deniszh
Copy link
Member

deniszh commented Jul 19, 2021

Looks good, @bom-d-van , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants