Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carbonserver: /list_query?leaft_only=true and /admin/info?scopes=config #454

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

bom-d-van
Copy link
Member

@bom-d-van bom-d-van commented Mar 17, 2022

Two goodies are introduced in this MR:

  • carbonserver: exposes configs in /admin/info api endpoint, with scope filter support
  /admin/info now also returns raw config file content. And users can also specify what info they prefer to see
  in the api call.
  • carbonserver: /list_query support leaf_only parameter
  /list_query was originally introduced to support looking up metrics usages in a namespace/prefix with globbing syntax.
  However, it is also nice to allow it to only check usages of an query without walking down the whole tree.
  
  Example metric tree:
  sys.app.host
  sys.app.host.cpu.core1
  sys.app.host.cpu.core2
  
  with /list_query?target=sys.app.host, go-cabron would return all the metrics listed above.
  with /list_query?target=sys.app.host&leaf_only=true, go-carbon would return only sys.app.host.

@bom-d-van bom-d-van force-pushed the carbonserver/list-query-depth-and-config-info branch from 0f1c465 to 5c1855b Compare March 17, 2022 09:31
/list_query was originally introduced to support looking up metrics usages in a namespace/prefix with globbing syntax.
However, it is also nice to allow it to only check usages of an query without walking down the whole tree.

Example metric tree:
    sys.app.host
    sys.app.host.cpu.core1
    sys.app.host.cpu.core2

with /list_query?target=sys.app.host, go-cabron would return all the metrics listed above.
with /list_query?target=sys.app.host&leaf_only=true, go-carbon would return only sys.app.host.
… filter support

/admin/info now also returns raw config file content. And users can also specify what info they prefer to see
in the api call.
@bom-d-van bom-d-van force-pushed the carbonserver/list-query-depth-and-config-info branch from 5c1855b to 7aaa759 Compare March 17, 2022 13:39
@bom-d-van bom-d-van merged commit 5683a8b into master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant