quota: add two unit tests for proper enforcement #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
one of the report stacktraces:
```
==================
WARNING: DATA RACE
Write at 0x00c0212813e0 by goroutine 28:
github.com/go-graphite/go-carbon/carbonserver.(*trieIndex).applyQuotas()
/Users/xhu/go/src/github.com/go-graphite/go-carbon/carbonserver/trie.go:1770 +0x580
github.com/go-graphite/go-carbon/carbonserver.TestTrieQuotaConcurrentApplyAndEnforce.func2()
/Users/xhu/go/src/github.com/go-graphite/go-carbon/carbonserver/trie_test.go:1500 +0x278
Previous read at 0x00c0212813e0 by goroutine 20:
github.com/go-graphite/go-carbon/carbonserver.(*trieIndex).throttle()
/Users/xhu/go/src/github.com/go-graphite/go-carbon/carbonserver/trie.go:2156 +0x228
github.com/go-graphite/go-carbon/carbonserver.TestTrieQuotaConcurrentApplyAndEnforce()
/Users/xhu/go/src/github.com/go-graphite/go-carbon/carbonserver/trie_test.go:1525 +0x5e4
testing.tRunner()
/opt/homebrew/Cellar/go/1.18.1/libexec/src/testing/testing.go:1439 +0x18c
testing.(*T).Run.func1()
/opt/homebrew/Cellar/go/1.18.1/libexec/src/testing/testing.go:1486 +0x44
```
|
pushed one more commit (502187f) for resolving go test -race bugs: https://github.com/go-graphite/go-carbon/runs/6590273149?check_suite_focus=true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two tests are for covering fixes made in #467.
More specifically, for commit 47f59ba and 653a7f0.