Factor for physical size for sparse mode. For sparse mode I added config variable which applies to logical size… #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in order to get physical size of the metric
timtofan
approved these changes
Aug 30, 2022
grzkv
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a new metrics are sent to go-carbon, if physical size quota is enabled, go-carbon would use its logical size as physical size (based on its matching schema). But with sparse mode, it means that the dynamically generated physical size is much larger than its actual disk size. This might causes unnecessary throttling.
To solve this problem I added factor multiplier PhysicalSizeFactor (0.75 by default) which allows to reduce physical in case if sparse mode is on:
metric_physical_size = PhysicalSizeFactor * metric_logical_size