Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor for physical size for sparse mode. For sparse mode I added config variable which applies to logical size… #491

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

auguzun
Copy link
Contributor

@auguzun auguzun commented Aug 30, 2022

Currently, when a new metrics are sent to go-carbon, if physical size quota is enabled, go-carbon would use its logical size as physical size (based on its matching schema). But with sparse mode, it means that the dynamically generated physical size is much larger than its actual disk size. This might causes unnecessary throttling.
To solve this problem I added factor multiplier PhysicalSizeFactor (0.75 by default) which allows to reduce physical in case if sparse mode is on:
metric_physical_size = PhysicalSizeFactor * metric_logical_size

… in order to get physical size of the metric
@auguzun auguzun merged commit 9f83eef into master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants