Use intermediate chan to expedite gRPC render cache #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtofan
reviewed
Feb 8, 2023
timtofan
reviewed
Feb 8, 2023
timtofan
reviewed
Feb 8, 2023
timtofan
reviewed
Feb 8, 2023
timtofan
approved these changes
Feb 8, 2023
added 2 commits
February 8, 2023 16:32
Before this commit, render responses were cached when the whole response was streamed to the client. This caused slowing requests waiting for that cache to be populated. Now, by using an intermediate channel when caching is enabled, we do not wait until the request is streamed.
emadolsky
force-pushed
the
emadolsky/use-intermediate-channel-to-cache-grpc-render-faster
branch
from
1d702c5
to
256be79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, render responses were cached when the whole response was streamed to the client. This caused slowing requests waiting for that cache to be populated. Now, by using an intermediate channel when caching is enabled, we do not wait until the request is streamed.