fix: if not kratos context then panic will result #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
当ctx不是kratos的context，则app.Name()会导致panic
|
场景，当使用kratos编写GRPC服务，而在其他项目中(比如gin的传统HTTP项目)使用kratos grpc client 和tracing middleware的时候，此时metadata里面获取的上下文就不是kratos，如果不判断，则会导致app.Name() panic |
Codecov Report
@@ Coverage Diff @@
## main #1338 +/- ##
==========================================
+ Coverage 62.91% 63.03% +0.11%
==========================================
Files 61 61
Lines 2823 2824 +1
==========================================
+ Hits 1776 1780 +4
+ Misses 898 896 -2
+ Partials 149 148 -1
Continue to review full report at Codecov.
|
longXboy
reviewed
Aug 15, 2021
daemon365
approved these changes
Aug 15, 2021
|
LGTM |
longXboy
approved these changes
Aug 15, 2021
zouyx
pushed a commit
to zouyx/kratos
that referenced
this pull request
Aug 24, 2021
* fix: if not kratos context panic 当ctx不是kratos的context，则app.Name()会导致panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
当ctx不是kratos的context，则app.Name()会导致panic