Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix a few function names on comments #2430

Merged
merged 4 commits into from
Jan 9, 2023
Merged

chore: fix a few function names on comments #2430

merged 4 commits into from
Jan 9, 2023

Conversation

cuishuang
Copy link
Contributor

No description provided.

Signed-off-by: cui fliter <imcusg@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022

Codecov Report

Merging #2430 (9a09e55) into main (69fcd50) will increase coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2430      +/-   ##
==========================================
+ Coverage   84.95%   85.23%   +0.28%     
==========================================
  Files          88       88              
  Lines        3788     3826      +38     
==========================================
+ Hits         3218     3261      +43     
+ Misses        402      391      -11     
- Partials      168      174       +6     
Impacted Files Coverage Δ
encoding/form/proto_encode.go 71.03% <ø> (ø)
transport/http/codec.go 59.61% <ø> (ø)
selector/global.go 83.33% <0.00%> (-16.67%) ⬇️
middleware/metadata/metadata.go 92.00% <0.00%> (-8.00%) ⬇️
app.go 83.78% <0.00%> (-2.08%) ⬇️
transport/http/server.go 74.50% <0.00%> (-1.33%) ⬇️
log/filter.go 95.23% <0.00%> (-0.32%) ⬇️
options.go 100.00% <0.00%> (ø)
log/level.go 100.00% <0.00%> (ø)
config/config.go 54.66% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@demoManito
Copy link
Member

transport/http/codec.go need to adjust github.com/go-kratos/kratos to the bottom of import

Signed-off-by: cui fliter <imcusg@gmail.com>
@cuishuang
Copy link
Contributor Author

transport/http/codec.go need to adjust github.com/go-kratos/kratos to the bottom of import

ok

transport/http/codec.go Outdated Show resolved Hide resolved
Signed-off-by: cui fliter <imcusg@gmail.com>
tonybase
tonybase previously approved these changes Oct 18, 2022
Casper-Mars
Casper-Mars previously approved these changes Oct 21, 2022
@shenqidebaozi
Copy link
Member

Please resolve the conflict

@cuishuang
Copy link
Contributor Author

Please resolve the conflict

done

@shenqidebaozi
Copy link
Member

It seems that there is no new submission

Signed-off-by: cui fliter <imcusg@gmail.com>
@cuishuang cuishuang dismissed stale reviews from Casper-Mars and tonybase via 9a09e55 November 10, 2022 06:08
@cuishuang
Copy link
Contributor Author

It seems that there is no new submission

Please confirm if it is possible to merge now

@shenqidebaozi shenqidebaozi changed the title fix a few function names on comments chore: fix a few function names on comments Jan 9, 2023
@shenqidebaozi shenqidebaozi merged commit 9cc1047 into go-kratos:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants