fix(log): toString float32 precision loss and convert uint use FormatUint
#2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoManito
force-pushed
the
fix/float32-precision-loss
branch
from
1f07769
to
50e15f8
Compare
Codecov Report
@@ Coverage Diff @@
## main #2461 +/- ##
=======================================
Coverage 84.80% 84.81%
=======================================
Files 88 88
Lines 3797 3799 +2
=======================================
+ Hits 3220 3222 +2
Misses 407 407
Partials 170 170
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
demoManito
force-pushed
the
fix/float32-precision-loss
branch
from
8d3e397
to
849ce08
Compare
demoManito
changed the title
FormatUint
tonybase
approved these changes
Oct 19, 2022
xiongpan828
pushed a commit
to xiongpan828/kratos
that referenced
this pull request
Jan 5, 2023
…tUint` (go-kratos#2461) * fix(log): toString float32 precision loss * convert uint to string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
float32
Convert string precision loss
switch v := v.(type) { case float32: - key = strconv.FormatFloat(float64(v), 'f', -1, 64) + key = strconv.FormatFloat(float64(v), 'f', -1, 32)uint
Convert uint with
Itoa, will be treated as a signed int conversion,MaxUintwill be converted to - 1, the correct return should be 18446744073709551615Which issue(s) this PR fixes (resolves / be part of):
Other special notes for the reviewers: