Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(encoding/form): add unit test and code style modift #2467

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

demoManito
Copy link
Member

Description (what this PR does / why we need it):

code style modify

Which issue(s) this PR fixes (resolves / be part of):

part of #2354

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2022

Codecov Report

Merging #2467 (476750f) into main (dcae38d) will increase coverage by 0.38%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2467      +/-   ##
==========================================
+ Coverage   84.91%   85.30%   +0.38%     
==========================================
  Files          88       88              
  Lines        3799     3797       -2     
==========================================
+ Hits         3226     3239      +13     
+ Misses        405      388      -17     
- Partials      168      170       +2     
Impacted Files Coverage Δ
encoding/form/form.go 65.71% <0.00%> (ø)
encoding/form/proto_decode.go 61.77% <100.00%> (+8.03%) ⬆️
config/file/watcher.go 59.37% <0.00%> (-6.25%) ⬇️
config/file/file.go 61.90% <0.00%> (-4.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tonybase tonybase merged commit a1a2b9d into go-kratos:main Nov 8, 2022
@demoManito demoManito deleted the test/encoding/form branch November 8, 2022 02:35
xiongpan828 pushed a commit to xiongpan828/kratos that referenced this pull request Jan 5, 2023
)

* test(encoding/form): add unit test and code style modift

* fix test

* add populateRepeatedField test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants