Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(encoding/form): failed to decode form map type #2468

Merged
merged 1 commit into from
Jun 16, 2023
Merged

fix(encoding/form): failed to decode form map type #2468

merged 1 commit into from
Jun 16, 2023

Conversation

demoManito
Copy link
Member

@demoManito demoManito commented Oct 22, 2022 •
edited

Description (what this PR does / why we need it):

The field is of type map and cannot be decode. (proto type map<string,string> cannot be decode)
image

修复 form 对 map 类型的错误解析，导致无法拿到 map 的数据

Which issue(s) this PR fixes (resolves / be part of):

resolves #2495

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2022 •
edited

Codecov Report

Merging #2468 (96e5de8) into main (e86ad24) will increase coverage by 0.03%.
The diff coverage is 80.64%.

❗ Current head 96e5de8 differs from pull request most recent head 4772321. Consider uploading reports for the commit 4772321 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2468      +/-   ##
==========================================
+ Coverage   84.42%   84.46%   +0.03%     
==========================================
  Files          88       88              
  Lines        3936     3958      +22     
==========================================
+ Hits         3323     3343      +20     
- Misses        437      438       +1     
- Partials      176      177       +1
Impacted Files Coverage Δ
encoding/form/proto_decode.go 63.56% <80.64%> (+1.78%) ⬆️

... and 1 file with indirect coverage changes

@demoManito demoManito force-pushed the fix/encoding/form/decode-map branch 6 times, most recently from 7d2513f to e8b6609 Compare October 23, 2022 14:22
@demoManito demoManito changed the title fix(encoding/form): failed to decode the map type fix(encoding/form): description failed to decode the map type Oct 23, 2022
@demoManito demoManito force-pushed the fix/encoding/form/decode-map branch 4 times, most recently from 88ee7ec to 0098d46 Compare October 26, 2022 03:45
@demoManito demoManito changed the title fix(encoding/form): description failed to decode the map type fix(encoding/form): failed to decode the map type Oct 26, 2022
@demoManito demoManito changed the title fix(encoding/form): failed to decode the map type fix(encoding/form): failed to decode map Oct 26, 2022
@demoManito demoManito force-pushed the fix/encoding/form/decode-map branch 2 times, most recently from c06d993 to 9ba590f Compare March 23, 2023 03:44
@demoManito
Copy link
Member Author

@haiyux PTAL

@demoManito demoManito changed the title fix(encoding/form): failed to decode map fix(encoding/form): failed to decode form map type Mar 24, 2023
@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

image Need to rerun @haiyux

@demoManito demoManito force-pushed the fix/encoding/form/decode-map branch 2 times, most recently from f12d358 to 0ee077a Compare June 2, 2023 06:19
@demoManito demoManito force-pushed the fix/encoding/form/decode-map branch from 0ee077a to 4772321 Compare June 8, 2023 09:53
@demoManito
Copy link
Member Author

@shenqidebaozi PTAL

@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@奇迹的包子PTA l

@shenqidebaozi shenqidebaozi removed the request for review from tonybase June 16, 2023 11:53
@shenqidebaozi shenqidebaozi merged commit fcd3b18 into go-kratos:main Jun 16, 2023
33 checks passed
@demoManito demoManito deleted the fix/encoding/form/decode-map branch June 19, 2023 05:57
@tonybase tonybase mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenqidebaozi shenqidebaozi shenqidebaozi approved these changes

@daemon365 daemon365 daemon365 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to resolve the map type of the form
5 participants
@demoManito @codecov-commenter @kratos-ci-bot @shenqidebaozi @daemon365