Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/protoc-gen-go-http): add comment to http server interface method #2657

Merged
merged 1 commit into from
Feb 21, 2023
Merged

feat(cmd/protoc-gen-go-http): add comment to http server interface method #2657

merged 1 commit into from
Feb 21, 2023

Conversation

thinkgos
Copy link
Contributor

@thinkgos thinkgos commented Feb 9, 2023

Description (what this PR does / why we need it):

add comment to http server interface, we can find the method use.

Which issue(s) this PR fixes (resolves / be part of):

easy to find what is the http server method use.

Other special notes for the reviewers:

nothing

@codecov-commenter
Copy link

Codecov Report

Merging #2657 (4d50ddb) into main (7def38a) will not change coverage.
The diff coverage is n/a.

❗ Current head 4d50ddb differs from pull request most recent head 509551b. Consider uploading reports for the commit 509551b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #2657   +/-   ##
=======================================
  Coverage   84.89%   84.89%           
=======================================
  Files          88       88           
  Lines        3873     3873           
=======================================
  Hits         3288     3288           
  Misses        411      411           
  Partials      174      174           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenqidebaozi shenqidebaozi merged commit d0b1d84 into go-kratos:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants