Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package path to filepath #2672

Merged
merged 4 commits into from
Mar 26, 2023
Merged

Conversation

songzhibin97
Copy link
Member

// Package filepath implements utility routines for manipulating filename paths
// in a way compatible with the target operating system-defined file paths.
//
// The filepath package uses either forward slashes or backslashes,
// depending on the operating system. To process paths such as URLs
// that always use forward slashes regardless of the operating
// system, see the path package.
// Package path implements utility routines for manipulating slash-separated
// paths.
//
// The path package should only be used for paths separated by forward
// slashes, such as the paths in URLs. This package does not deal with
// Windows paths with drive letters or backslashes; to manipulate
// operating system paths, use the path/filepath package.

Filepath is used to process file paths path is used to process url paths

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #2672 (a8a5c26) into main (f47a238) will not change coverage.
The diff coverage is n/a.

❗ Current head a8a5c26 differs from pull request most recent head 2ace971. Consider uploading reports for the commit 2ace971 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #2672   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files          88       88           
  Lines        3891     3891           
=======================================
  Hits         3299     3299           
  Misses        418      418           
  Partials      174      174           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

daemon365
daemon365 previously approved these changes Mar 23, 2023
@daemon365
Copy link
Member

daemon365 commented Mar 23, 2023

Please resolve the conflict and fix lint

@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Resolve the conflict and fix the lint

@daemon365 daemon365 added the LGTM label Mar 23, 2023
@shenqidebaozi shenqidebaozi merged commit 99ccd00 into go-kratos:main Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants