Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add http.ResponseController type alias #2713

Merged
merged 2 commits into from
Mar 26, 2023
Merged

add http.ResponseController type alias #2713

merged 2 commits into from
Mar 26, 2023

Conversation

czyt
Copy link
Contributor

@czyt czyt commented Mar 9, 2023

No description provided.

@shenqidebaozi
Copy link
Member

please merge master

@czyt
Copy link
Contributor Author

czyt commented Mar 9, 2023 •
edited
Loading

please merge master

ok,latest branch was merged .pls review!@shenqidebaozi

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023 •
edited
Loading

Codecov Report

Merging #2713 (ee6970d) into main (7eca8f8) will not change coverage.
The diff coverage is n/a.

❗ Current head ee6970d differs from pull request most recent head 3630159. Consider uploading reports for the commit 3630159 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #2713   +/-   ##
=======================================
  Coverage   84.88%   84.88%           
=======================================
  Files          88       88           
  Lines        3889     3889           
=======================================
  Hits         3301     3301           
  Misses        413      413           
  Partials      175      175

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@daemon365 daemon365 added the LGTM label Mar 23, 2023
@shenqidebaozi shenqidebaozi merged commit 6a4d17d into go-kratos:main Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenqidebaozi shenqidebaozi shenqidebaozi approved these changes

@daemon365 daemon365 daemon365 approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@czyt @shenqidebaozi @codecov-commenter @daemon365