Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make lint happy #2747

Merged
merged 2 commits into from
Mar 26, 2023
Merged

chore: make lint happy #2747

merged 2 commits into from
Mar 26, 2023

Conversation

yonwoo9
Copy link
Contributor

@yonwoo9 yonwoo9 commented Mar 18, 2023

Description (what this PR does / why we need it):

update comment

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Merging #2747 (fcf95da) into main (f47a238) will not change coverage.
The diff coverage is n/a.

❗ Current head fcf95da differs from pull request most recent head 96f7f46. Consider uploading reports for the commit 96f7f46 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #2747   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files          88       88           
  Lines        3891     3891           
=======================================
  Hits         3299     3299           
  Misses        418      418           
  Partials      174      174           
Impacted Files Coverage Δ
selector/p2c/p2c.go 94.59% <ø> (ø)
selector/wrr/wrr.go 93.33% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@demoManito
Copy link
Member

please rebase branch

@Cluas
Copy link
Contributor

Cluas commented Mar 22, 2023

I think commit message with chore: make lint happy will be better.

@demoManito
Copy link
Member

demoManito commented Mar 22, 2023

your branch should not contain committed changes.

  1. git reset --hard 6d1bec6
  2. git fetch origin/main
  3. git rebase origin/main

@yonwoo9 yonwoo9 changed the title chore: update comment chore: make lint happy Mar 22, 2023
@daemon365 daemon365 added the LGTM label Mar 23, 2023
@shenqidebaozi shenqidebaozi merged commit e273c51 into go-kratos:main Mar 26, 2023
@yonwoo9 yonwoo9 deleted the comment branch March 27, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants